Windows: fix unit tests & enable CI #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing process=True argument was causing all subsequent tests to fail on windows
Tom-Willemsen
force-pushed
the
windows_fix_unit_tests
branch
from
390837e
to
ea412fe
Compare
coretl
reviewed
Nov 1, 2024
| @@ -149,7 +149,7 @@ def flying_plan(): | |||
| "uid": ANY, | |||
| "data_key": data_key_name, | |||
| "mimetype": "application/x-hdf5", | |||
| "uri": "file://localhost" + str(tmp_path / "test-panda.h5"), | |||
| "uri": "file://localhost/" + str(tmp_path / "test-panda.h5").lstrip("/"), | |||
There was a problem hiding this comment.
What does one of these windows paths actually look like? Not sure what the right file:// semantics are for drive letter etc. What does a web browser show if you point to file://something_on_c_drive on windows?
There was a problem hiding this comment.
Web browsers (at least firefox, chrome and edge) do correctly understand a path like file://C:\Instrument\Var\logs\ioc\ARINST-20241030.log. Forward slashes rather than backslashes would also work - but the drive letter part is what it wants as far as i understand it.
coretl
approved these changes
Nov 1, 2024
ZohebShaikh
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Fix race condition in mock_signal_backend * Fix numpy datatypes in test_mock_signal_backend * Fix adaravis URI paths * Fix path in test_kinetix * Fix paths in simdetector tests * Loosen timings against race condition in test_sim_detector * Correct paths in test_advimba * Fix paths in test_eiger * Fix broken tests in test_signals * Fix tange test_base_device tests on Windows Missing process=True argument was causing all subsequent tests to fail on windows * Fix race conditions in tango tests * Use tango FQTRL to placate windows unit tests * Correct paths in fastcs tests * Correct path logic for windows compatibility * Slacken timings for race condition in test_sim_motor * Slacken race condition timings in test_motor * Enable windows CI builds * Try allowing asyncio time to clean up tasks * Object IDs on windows are uppercase * Try wait_for_wakeups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
windows-latestas part of the testing CI matrix.Motivation and Context
At isis we're running on windows, we'd like to be able to run the unit tests.
How Has This Been Tested?
See the CI runs.