Add test for context race condition #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
reviewed
Oct 18, 2024
tests/epics/signal/test_signals.py
Outdated
Comment on lines
914
to
916
| await ophyd_async_sig.connect() | ||
| ophyd_signal = EpicsSignal(ophyd_read) | ||
| ophyd_signal.wait_for_connection() |
There was a problem hiding this comment.
Can we put any timeouts in here, or does it just hang anyway?
There was a problem hiding this comment.
It hangs either way but I've added it anyway
|
Linting seems broken on main so I don't think it's related to this change specifically |
Yes, mainly bluesky/bluesky#1809 |
coretl
approved these changes
Oct 29, 2024
ZohebShaikh
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Add test for context race condition * Add timeout to wait on connection in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test to cover DiamondLightSource/dodal#791.
To test:
aiocaconfirm this test times outpip install git+https://github.com/DiamondLightSource/aioca.git@contextsand confirm it passesNote we shouldn't merge this until the linked aioca branch is released