Fix race condition in set_and_wait_for_value #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue than you set and fix potential race condition
4 tasks
coretl
reviewed
Jul 16, 2024
There was a problem hiding this comment.
I spend half an hour playing with typing, and I now see why you made it two functions. I think this is a pretty teachable API, so happy with the signature. Spotted a further possible race condition (which would only manifest with a heavily loaded IOC and network congestion), which we might want to consider...
coretl
reviewed
Jul 16, 2024
coretl
reviewed
Jul 18, 2024
coretl
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453
set_and_wait_for_other_valuefor monitoring a different value than setting