Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log formatter with colour #277

Merged
merged 3 commits into from
May 3, 2024
Merged

Add log formatter with colour #277

merged 3 commits into from
May 3, 2024

Conversation

olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented May 2, 2024

Color or colour?!
Fixes part of ##195

Copy link
Collaborator

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour :)

It looks good to me from a brief poke. The only thing I think I would prefer is the log.py to be in ophyd_async/log.py, and not in core. It doesn't contribute to the core constituent parts of the framework, its a nice tool.

(also remember to move the test relative, it's something I frequently forget).

Copy link
Collaborator

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent lgtm :)

@olliesilvester olliesilvester merged commit 995c126 into main May 3, 2024
18 checks passed
@olliesilvester olliesilvester deleted the add_formatted_logging branch May 3, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants