Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad plugin stats #178

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ad plugin stats #178

wants to merge 1 commit into from

Conversation

DiamondJoseph
Copy link
Contributor

Initial implementation of potential solution to #177

Adds a pair of example enums to the NDStatsPlugin, allows configuring appropriate fields for that plugin.
Allows configuring an ADBase with a dict of {suffix: PluginClass} that will then later enable configurable use of ScalarSigs in the HDFWriter

Submitting mostly as a RFC and first attempt: From the i22 pilatus and AdAravis cameras, the Stats plugin was hardcoded, without enabling the Statistics calculation, or allowing other fields. Ideally, this behaviour would be configurable from here?

@DiamondJoseph
Copy link
Contributor Author

I don't know if this has already been discussed for ophyd-async, just something I stumbled across while porting the i22 cameras.

@DiamondJoseph
Copy link
Contributor Author

I see that SingleTriggerDet is already taking a kwargs of Plugins

class SingleTriggerDet(StandardReadable, Triggerable):
    def __init__(
        self,
        drv: ADBase,
        read_uncached: Sequence[SignalR] = (),
        name="",
        **plugins: NDPluginBase,
    ) -> None:
        self.drv = drv
        self.__dict__.update(plugins)
    ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant