Remove ScalarSigs from FooDetector

bluesky · May 3, 2024 · 966eb49 · 966eb49
1 parent ddfdcef
commit 966eb49
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/docs/examples/foo_detector.py b/docs/examples/foo_detector.py
@@ -60,8 +60,8 @@ def __init__(
         drv_suffix="cam1:",
         hdf_suffix="HDF1:",
         name="",
-        **scalar_sigs: str,
     ):
+        # Must be children to pick up connect
         self.drv = FooDriver(prefix + drv_suffix)
         self.hdf = NDFileHDF(prefix + hdf_suffix)
 
@@ -72,7 +72,6 @@ def __init__(
                 directory_provider,
                 lambda: self.name,
                 ADBaseShapeProvider(self.drv),
-                **scalar_sigs,
             ),
             config_sigs=(self.drv.acquire_time,),
             name=name,

diff --git a/docs/how-to/make-a-standard-detector.rst b/docs/how-to/make-a-standard-detector.rst
@@ -45,8 +45,8 @@ If the :py:class:`FooDriver` exposes :py:class:`Signal` that should be read as c
 Writing a non-AreaDetector StandardDetector
 -------------------------------------------
 
-A non-AreaDetector `StandardDetector` should implement the `DetectorControl` and `DetectorWriter` protocol directly.
-Here we construct a `DetectorControl` that co-ordinates signals on a PandA PositionCapture block which (analogously to the AreaDetector "Driver") is a child device of the `StandardDetector` implementation, while the `DetectorControl` is not.
+A non-AreaDetector `StandardDetector` should implement `DetectorControl` and `DetectorWriter` directly.
+Here we construct a `DetectorControl` that co-ordinates signals on a PandA PositionCapture block which is a child device of the `StandardDetector` implementation, (the `DetectorControl` is not).
 
 .. literalinclude:: ../../src/ophyd_async/panda/_panda_controller.py
    :pyobject: PandaPcapController