Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary addEventListener call for video #7433

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove unnecessary addEventListener call for video #7433

merged 1 commit into from
Jan 14, 2025
+0 −3

Conversation

IslamRustamov
Copy link
Contributor

@IslamRustamov IslamRustamov commented Jan 11, 2025 •
edited
Loading

Problem:

useVideoElement repeatedly adds listener for volumechange event. We already add that listener here

Solution:

Removed call to addEventListener that's not needed

@mozzius mozzius merged commit 1fc889b into bluesky-social:main Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IslamRustamov @mozzius