Add frontend build #24
Conversation
ping-viewer-next-frontend/src/components/widgets/DynamicForm.vue
Outdated
Show resolved
Hide resolved
ping-viewer-next-frontend/src/components/widgets/DynamicFormGenerator.vue
Outdated
Show resolved
Hide resolved
ping-viewer-next-frontend/src/components/widgets/Sonar360Menu.vue
Outdated
Show resolved
Hide resolved
RaulTrombin
force-pushed
the
add_frontend_build
branch
2 times, most recently
from
a313cc7 to
8fdcb53
Compare
|
@patrickelectric Moved these components to a post-pull request. |
RaulTrombin
force-pushed
the
add_frontend_build
branch
from
8fdcb53 to
ff02a6a
Compare
| uses: actions/[email protected] | ||
| with: | ||
| name: dist | ||
| path: ./ping-viewer-next-frontend/dist |
There was a problem hiding this comment.
I'm not sure if I follow, we are already building it with build.rs
There was a problem hiding this comment.
currently we don't, only if the feature flag is enabled, so users only need to set npm/bun/front-end stuff if they want it.
The frontend is built only a single time and shared to the next actions to embeed it.
We have the flags:
build-frontend [embed-frontend]
and
embed-frontend itself
if this features isn't requested, it will only embed the simple .html on src/server/rest/
There was a problem hiding this comment.
I'm not following. Why are we building this in a different step ?
And why are we not building it with build.rs on the step that we are downloading it ?
There was a problem hiding this comment.
I'm not following. Why are we building this in a different step ? And why are we not building it with build.rs on the step that we are downloading it ?
To users choose if they want to setup the frontend related features on computer or not.
Also had issues to build the frontend on specific targets such armv7/aarch64 using Vue/Bun , and even we'll need to set an special container to cross compiling it inside.
So the built frontend is just embeded on the build steps.
There was a problem hiding this comment.
I just tested here, and a simple curl -fsSL https://bun.sh/install | bash should work.
Btw, we use bun in cockpit.
| @@ -0,0 +1,5 @@ | |||
| [*.{js,jsx,ts,tsx,vue}] | |||
ping-viewer-next-frontend/.gitignore
Outdated
| @@ -0,0 +1,22 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
Can you minize this file to use only what we need ?
ping-viewer-next-frontend/README.md
Outdated
| @@ -0,0 +1,79 @@ | |||
| # Vuetify (Default) | |||
|
|
||
| <script setup> | ||
| import { ref } from "vue"; | ||
| import WebsocketClient from "../widgets/WebsocketClient.vue"; |
There was a problem hiding this comment.
Please use path alias like @
| const isCollapsed = ref(false); | ||
|
|
||
| const components = { | ||
| WebsocketClient, |
There was a problem hiding this comment.
Can we use 4 spaces as the other parts of the project ?
| @@ -0,0 +1,5 @@ | |||
| # Pages | |||
|
|
||
| // Plugins | ||
| import vuetify from "./vuetify"; | ||
| // import router from '@/router' |
RaulTrombin
force-pushed
the
add_frontend_build
branch
2 times, most recently
from
182236a to
ac97025
Compare
| @@ -0,0 +1,4 @@ | |||
| indent_style = space | |||
There was a problem hiding this comment.
This file is unnecessary
|
@RaulTrombin needs rebase |
RaulTrombin
force-pushed
the
add_frontend_build
branch
from
ac97025 to
2c5c44e
Compare
RaulTrombin
force-pushed
the
add_frontend_build
branch
from
2c5c44e to
673318e
Compare
RaulTrombin
force-pushed
the
add_frontend_build
branch
from
673318e to
497756b
Compare
This PR adds a front-end project to the repository.
The project was built with Bun, along with Vue, Vuetify, and TailwindCSS.
The built front-end is embedded in the release binaries on CI.