Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removing empty recording folders (#4227) #4231

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 7, 2025

Fixes #4227

@aler9 aler9 force-pushed the fix/record-emptydirs branch from b4aa8a9 to 57011f1 Compare February 7, 2025 16:01
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (a1c6da8) to head (57011f1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4231      +/-   ##
==========================================
+ Coverage   56.50%   56.60%   +0.09%     
==========================================
  Files         202      202              
  Lines       20656    20679      +23     
==========================================
+ Hits        11672    11705      +33     
+ Misses       8115     8108       -7     
+ Partials      869      866       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit d31f1ab into main Feb 7, 2025
8 checks passed
@aler9 aler9 deleted the fix/record-emptydirs branch February 7, 2025 16:07
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This issue is mentioned in release v1.11.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty directories are not being deleted as expected after fix recordDeleteAfter
1 participant