Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal LoadException #2566

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

cschramm
Copy link
Member

It looks like this rarely ever manifests, but we erroneously stopped catching the exception in c71294c.

It looks like this rarely ever manifests, but we erroneously stopped catching the exception in blueman-project@c71294c.
@cschramm cschramm requested a review from infirit December 17, 2024 23:40
Copy link
Contributor

@infirit infirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a common error but as it's fatal, should we also include it in 2.4.4?

@cschramm
Copy link
Member Author

cschramm commented Dec 18, 2024

Makes sense, yes.

I think this did not bite us yet because it is not reachable with affected versions of blueman alone. You either have to modify /org/blueman/general/plugin-list, e.g. to ['DhcpClient'], or adopt such a value from blueman 2.0 which seems to be the case in Debian #1082668. Enabling a plugin in the plugin manager will automatically disable all conflicting ones, so that e.g. DhcpClient will not be set without !NMPANSupport.

@cschramm cschramm merged commit 657c1dc into blueman-project:main Dec 18, 2024
22 checks passed
@cschramm cschramm deleted the loadexception branch December 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants