Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fix: Make search button available after device list becomes empty #2513

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

astcri
Copy link
Contributor

@astcri astcri commented Oct 17, 2024

Problem
The search button becomes unavailable after the device list is empty.

Cause
The _update_button() function receives None when the device list becomes empty, causing the sensitivity of the search button to be disabled if the argument (adapter) is None.

Solution
Pass the instance variable of ManagerDeviceList, Adapter, to the _update_button() function.

Copy link

Copy link
Contributor

@infirit infirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschramm we should include this in the next stable, I'll open a PR.

@astcri good catch.

@infirit infirit added this to the 2.4.4 milestone Oct 17, 2024
@infirit infirit mentioned this pull request Oct 17, 2024
@cschramm cschramm merged commit 2714071 into blueman-project:main Oct 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants