Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcache with context #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dragonsinth
Copy link

No description provided.

@dragonsinth dragonsinth mentioned this pull request Jun 18, 2019
@greyireland
Copy link

update readme

@alexanderbolgov-ef
Copy link

would be great to have this change merged

@romansonrai
Copy link

No tests for Context timeout/Context related functionality

@dragonsinth
Copy link
Author

I didn't see a compelling need; the functional changes are almost nothing; it's mostly just plumbing ctx around everywhere.

@romansonrai
Copy link

For the most part I certainly agree with you, but the changes in singleflight.go (Do function) are comparatively substantial. And that would be the only place I would include additional tests.

@dragonsinth
Copy link
Author

Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged.

@romansonrai
Copy link

romansonrai commented Feb 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants