Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Fix: (one of) fatal error "No entry was found for 'comingSoon'" #929

Closed
wants to merge 1 commit into from
Closed

Fix: (one of) fatal error "No entry was found for 'comingSoon'" #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/RestApi/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public function get_current_settings() {
}

$settings = array(
'comingSoon' => container()->get( 'comingSoon' )->is_enabled(),
'comingSoon' => container()->has( 'comingSoon' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the meaning behind the comingSoon property. The has() check just looks to see if the service is registered in the container. We should look into why the coming soon service doesn't exist yet and fix that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wrote that first then realised there was more going on than i quite understood.

'autoUpdatesAll' => $major && $plugins && $themes,
'autoUpdatesMajorCore' => $major,
'autoUpdatesMinorCore' => $minor,
Expand Down
Loading