Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Bump Performance to 2.5.0 #1549

Closed
wants to merge 1 commit into from
Closed

Bump Performance to 2.5.0 #1549

wants to merge 1 commit into from

Conversation

arunshenoy99
Copy link
Member

Proposed changes

  1. Clean up code to follow code standards
  2. Add Health Checks
  3. Fix: avoid useless loading of scripts
  4. Fix Skip 404 settings appearance
  5. Fix missing styles on the Brand Plugin dashboard

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Jan 29, 2025

Bluehost Brand Plugin    Run #12946

Run Properties:  status check failed Failed #12946  •  git commit 1f4e37a904: Bump Performance to 2.5.0
Project Bluehost Brand Plugin
Branch Review update/performance
Run status status check failed Failed #12946
Run duration 32m 16s
Commit git commit 1f4e37a904: Bump Performance to 2.5.0
Committer arunshenoy99
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 406
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-solutions/tests/cypress/integration/wp-plugins-installation-check.cy.js • 1 failed test

View Output Video

Test Artifacts
My Plugins and Tools in Plugin App > Yoast and Jetpack not installed Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/3-ecommerce-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video

Copy link

cypress bot commented Jan 29, 2025

Bluehost Brand Plugin    Run #12947

Run Properties:  status check failed Failed #12947  •  git commit a842f01670 ℹ️: Merge 1f4e37a9040e134bb8d57820b8831aac4751bf6b into dd711f235c1ba2e7be364cd7dd1d...
Project Bluehost Brand Plugin
Branch Review update/performance
Run status status check failed Failed #12947
Run duration 35m 54s
Commit git commit a842f01670 ℹ️: Merge 1f4e37a9040e134bb8d57820b8831aac4751bf6b into dd711f235c1ba2e7be364cd7dd1d...
Committer Arun Shenoy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

Tests for review

Failed  solutions-app.cy.js • 1 failed test

View Output Video

Test Artifacts
My Plugins and Tools in Plugin App > My Plugins & Tools displays with Solution Test Replay Screenshots Video
Failed  wp-plugins-installation-check.cy.js • 1 failed test

View Output Video

Test Artifacts
My Plugins and Tools in Plugin App > Yoast and Jetpack not installed Test Replay Screenshots Video
Flakiness  2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video
Flakiness  3-ecommerce-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video
Flakiness  3-ecommerce-onboarding-flow/get-started-experience.cy.js • 1 flaky test

View Output Video

Test Artifacts
Start Setup WP Experience Page > Check if events API call being made after radio buttons are clicked Test Replay Screenshots Video

@circlecube
Copy link
Member

Will take care of this update in the new repository at https://github.com/newfold-labs/wp-plugin-bluehost

@circlecube circlecube closed this Jan 30, 2025
@circlecube circlecube deleted the update/performance branch January 30, 2025 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants