This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
feature/Launchpad with view & add buttons - PRESS4 509 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/Launchpad with view & add buttons - PRESS4 509
1 flaky test on run #8087 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Top Priority Page > Check for API events when different cards are selected |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #1040 ↗︎
Posting previous feedback from @wpalani in order to preserve context here:
|
@ramyakrishnai It looks like tests didn't run with the last commit. Any ideas why? |
@wpalani Would you be able to do another review to see if your concerns were addressed? |
@wpscholar I'm unsure why it didn't occur the previous time, but after editing it, it began. |
wpalani
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We will have a pages menu item
And there will be launchpads for each public content type
And there will be lanchpads for each public custom content type
And there will be a "view all" option for each type
And there will be an "add new" option for each type.
story - https://jira.newfold.com/browse/PRESS4-509
Type of Change
Checklist
Further comments
Created this for: #1023 so that tests run.