-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Prevent js file use from server configuration object #213
base: master
Are you sure you want to change the base?
Conversation
server configuration allow to set custom metadata. Metadata is loaded from a path and we aim to use object instead Closes bluehalo#212
Update custom metadata documentation file with a new chapter. Closes bluehalo#212
Thanks! Will be looking through this. |
Hi there. I've been pretty busy lately. However, I'm not sure about the idea of extending the config object to include functions. There is probably a better way, and I will be playing around with TypeScript project that includes |
I may understand your point of view and of course contrary to the sample I provided, people can provide metadata builder function instead of bare metadata object. It also means that we can dynamically create metadata, a functionality that is missing right now. We can only create them statically at server start. |
@Ahryman40k Do you have a sample TypeScript project somewhere where I can see this fix in action? |
I'm writing a typescript library that encapsulate your own as helper to produce FHIR microservices quickly, but it still under development. |
Please find a sample there: https://github.com/Ahryman40k/asymmetrik-sample Don't forget it's a POC and not a real development project. |
Thanks @Ahryman40k ! I'll be looking at this to really understand the problem. |
@zeevosec Have you take a look ? |
Hi there @Ahryman40k I have been super busy with other projects lately. I do understand the issue with dynamically requiring files within TypeScript projects. If I get around to it, we may write some kind of TypeScript compatible Server config mechanism, but until then you may have to just maintain a fork. Sorry! |
Would love to see this merged. We are using your great lib in one of our typescript based projects. Would help a lot to maintain a clean code base and setup tests. |
Me too ;) |
Hey I am going to revisit this and probably merge it. |
Do I need to sync with your repo then resubmit my work ? |
Hi, I am happy to merge this PR if you can resolve the merge conflicts |
Hello any updated for implemeting typescript to the project ? Thank you |
As discussed in Issue #212, please find here the corresponding pull request.
So, if you agree with adding such feature, you could merge it.
Hope I did well according your contributing note and nothing were missed.
Best regards,
Ahry