refactor: Replace ngx-bootstrap modals with cdk dialogs #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrassa
commented
Aug 15, 2023
jrassa
commented
- Initial steps towards migrating away from the ngx-bootstrap library in favor of using cdk. Cdk components have better a11y support and are style agnostic. We can still apply bootstrap styles to them, but gives us the options to move away from bootstrap in the future.
- Still using bootstrap styling for visual consistency.
- Replaced all modal usages in starter with dialog.
- Existing ngx-bootstrap modal components/services still available to ease migrations. Will remove in the future.
* Initial steps towards migrating away from the ngx-bootstrap library in favor of using cdk. Cdk components have better a11y support and are style agnostic. We can still apply bootstrap styles to them, but gives us the options to move away from bootstrap in the future. * Still using bootstrap styling for visual consistency. * Replaced all modal usages in starter with dialog. * Existing ngx-bootstrap modal components/services still available to ease migrations. Will remove in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.