Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More directives support #15

Merged
merged 10 commits into from
Dec 24, 2023
Merged

feat: More directives support #15

merged 10 commits into from
Dec 24, 2023

Conversation

bdlukaa
Copy link
Contributor

@bdlukaa bdlukaa commented Dec 24, 2023

Adds support for part, part of and library directives. Adds support for the augment keyword.

Additional resources

https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/feature-specification.md

@bdlukaa bdlukaa changed the title Directives feat: More directives support Dec 24, 2023
@bdlukaa bdlukaa marked this pull request as ready for review December 24, 2023 02:18
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add some simple tests?

@bdlukaa bdlukaa requested a review from spydon December 24, 2023 13:57
);
});

// test('augment library', () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out tesf

@bdlukaa
Copy link
Contributor Author

bdlukaa commented Dec 24, 2023

I removed the augment test. It looks like the parser is not parsing augment libraries correctly. Looks like it hasn't been released to stable yet.

@spydon spydon merged commit c6f5b00 into bluefireteam:main Dec 24, 2023
3 checks passed
@spydon
Copy link
Member

spydon commented Dec 24, 2023

@bdlukaa thanks for your contribution, released 0.4.0 including it.

@bdlukaa bdlukaa deleted the other_declarations branch December 24, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants