Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views and permissions cleanup #52

Merged
merged 4 commits into from
Nov 12, 2017
Merged

Views and permissions cleanup #52

merged 4 commits into from
Nov 12, 2017

Conversation

rnixx
Copy link
Member

@rnixx rnixx commented Nov 12, 2017

This PR includes the following changes:

  • Remove Authenticated role for bda.plone.orders: View Orders
    permission in rolmap.xml and add Vendor instead. We really do not
    want all authenticated users to be able to see all orders.

  • Move page templates to dedicated folder.

  • Move invoice related views from views.py to invoice.py.

  • Move order related views from views.py to order.py.

  • Move orders related views from views.py to orders.py.

  • Move general views from views.py to common.py.

@rnixx
Copy link
Member Author

rnixx commented Nov 12, 2017

Improves the situation in any case, done as PR for traceability reasons, thus I'll merge on my own.

@rnixx rnixx merged commit 722bc79 into master Nov 12, 2017
@rnixx rnixx deleted the rnixx-views-cleanup branch November 12, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant