Visprep #21
Merged
Visprep #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointless checks from GridDialog (the QSpinner makes sure the result is always within the set limits, no point checking again)
pklampros
reviewed
May 19, 2017
cliTest/testvisprepparser.cpp
Outdated
| { | ||
| VisPrepParser parser; | ||
| ArgumentHolder ah{"prog", "-pr", "foo"}; | ||
| REQUIRE_THROWS_WITH(parser.parse(ah.argc(), ah.argv()), Catch::Contains("Restricted visibilyt of 'foo' makes no sense, use a positive number or -1 for unrestricted")); |
There was a problem hiding this comment.
Minor: visibilyt -> visibility
pklampros
reviewed
May 19, 2017
cliTest/testvisprepparser.cpp
Outdated
| { | ||
| VisPrepParser parser; | ||
| ArgumentHolder ah{"prog", "-pr", "0.0"}; | ||
| REQUIRE_THROWS_WITH(parser.parse(ah.argc(), ah.argv()), Catch::Contains("Restricted visibilyt of '0.0' makes no sense, use a positive number or -1 for unrestricted")); |
There was a problem hiding this comment.
Minor: visibilyt -> visibility
pklampros
reviewed
May 19, 2017
depthmapXcli/visprepparser.cpp
Outdated
| if ( m_maxVisibility == 0.0) | ||
| { | ||
| std::stringstream message; | ||
| message << "Restricted visibilyt of '" << argv[i] << "' makes no sense, use a positive number or -1 for unrestricted"; |
There was a problem hiding this comment.
Minor: visibilyt -> visibility
pklampros
reviewed
May 19, 2017
depthmapXcli/runmethods.cpp
Outdated
| if ( gridSize > gp.getMax() || gridSize < gp.getMin()) | ||
| { | ||
| std::stringstream message; | ||
| message << "Chosen grid spacing " << gridSize << " is outside of the expected intervall of " |
There was a problem hiding this comment.
Minor: intervall -> interval
There was a problem hiding this comment.
Also, some tests for this exception?
|
Tricky, as run methods aren't really testable. That's why I tried out the calculation to a separate class in sala.
…On May 19, 2017 4:22:05 PM GMT+01:00, Petros Koutsolampros ***@***.***> wrote:
orange-vertex commented on this pull request.
> + auto mGraph =
loadGraph(clp.getFileName().c_str(),perfWriter);
+
+ std::cout << "Initial checks... " << std::flush;
+ auto state = mGraph->getState();
+ if (~state & MetaGraph::LINEDATA)
+ {
+ throw depthmapX::RuntimeException("Graph must have line
data before preparing VGA");
+ }
+ // set grid
+ QtRegion r = mGraph->getRegion();
+
+ GridProperties gp(__max(r.width(), r.height()));
+ if ( gridSize > gp.getMax() || gridSize < gp.getMin())
+ {
+ std::stringstream message;
+ message << "Chosen grid spacing " << gridSize << " is
outside of the expected intervall of "
Also, some tests for this exception?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#21 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
typos and some signed/unsigned warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prep steps for VGA to command line