Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump XcodeProj to 8.25.0 #139

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Bump XcodeProj to 8.25.0 #139

merged 1 commit into from
Dec 12, 2024

Conversation

Lommelun
Copy link
Contributor

Describe your changes
Bump XcodeProj version to latest (8.25.0)

Testing performed
Comparing a project that is using the new buildable folders with PBXFileSystemSynchronizedBuildFileExceptionSet now without XcodeProj failing with a generic error.

Additional context
XCLocalSwiftPackageReference and PBXFileSystemSynchronizedBuildFileExceptionSet were unsupported. New XcodeProj version supports these elements.

Signed-off-by: Even Gabrielsen <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (c48fb45) to head (562b946).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   97.05%   96.94%   -0.11%     
==========================================
  Files          52       52              
  Lines        2986     2982       -4     
==========================================
- Hits         2898     2891       -7     
- Misses         88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this @Lommelun 🙏

This ensures xcdiff no longer errors when dealing with Xcode 16 projects - will spawn a separate issue to add support for diffing the new element types.

@kwridan kwridan merged commit 99efe86 into bloomberg:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants