ci: use Node 20

- While the package says we support Node 18 the unit tests are using Node 20 features - Since the e2e loader test was added we now need to 'build' in 'pretest' - Fix prettier violations Signed-off-by: Ashley Claymore <[email protected]>
bloomberg · Sep 18, 2024 · 8c610b0 · 8c610b0
1 parent 45dd291
commit 8c610b0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,6 +11,10 @@ jobs:
         name: Test + Lint + Check
         runs-on: ubuntu-latest
         steps:
+            - uses: actions/checkout@v4
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: 20
             - run: npm ci
             - run: npm run check
             - run: npm run format:check

diff --git a/package.json b/package.json
@@ -38,6 +38,7 @@
         "gen-types": "tsc -p ./src/tsconfig.json --emitDeclarationOnly",
         "fixtures": "node --import=#r ./tests/fixture/_run.ts",
         "fixtures:watch": "node --watch-path ./tests/fixture/cases --import=#r ./tests/fixture/_run.ts",
+        "pretest": "npm run build",
         "test": "node --test --import=#r ./tests/*.test.ts",
         "test-ecosystem": "node --test --import=#r ./tests/ecosystem/ecosystem.test.ts",
         "format": "prettier . -w",

diff --git a/website/_includes/base.html b/website/_includes/base.html
@@ -27,7 +27,7 @@
     </head>
     <body>
         <header style="grid-column-start: 1; grid-column-end: -1; display: grid; grid-template-columns: 1fr 1fr">
-            <div style="background-color: #3178c6; flex-grow: 1; text-align: right;">
+            <div style="background-color: #3178c6; flex-grow: 1; text-align: right">
                 <h1 class="cds-t-h1">ts-</h1>
             </div>
             <div style="background-color: #f90; flex-grow: 1">

diff --git a/website/play/index.html b/website/play/index.html
@@ -50,7 +50,7 @@
     </head>
     <body>
         <div class="tsbs-wrapper">
-            <div style="background-color: #3178c6; grid-area: header-ts; text-align: right;">
+            <div style="background-color: #3178c6; grid-area: header-ts; text-align: right">
                 <h1 class="cds-t-h1">ts-</h1>
             </div>
             <div style="background-color: #f90; grid-area: header-js">