Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accuracy of query fingerprints with quoted string literals #5011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve accuracy of query fingerprints with quoted string literals #5011

wants to merge 1 commit into from
+61 −11

Conversation

LiSodium
Copy link

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

@LiSodium
Copy link
Author

/runtests

roborivers
roborivers suggested changes Feb 11, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/597 tests failed ⚠.

The first 10 failing tests are:
fdb_compat
sc_timepart_multiddl_generated
sc_downgrade
incremental_backup_load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

@mponomar mponomar Awaiting requested review from mponomar

@mohitkhullar mohitkhullar Awaiting requested review from mohitkhullar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiSodium @roborivers