R7: unlock mutexes before calling destroy on session obj #2022
Conversation
There was a problem hiding this comment.
Code review suggestions:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ util/walkback.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
There was a problem hiding this comment.
Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Error ⚠ .
Cbuild submission: Success ✓.
Regression testing: Success ✓.
There was a problem hiding this comment.
Sysbench Transactions Per Second (commit: a404f0e):
@@ sysbench/bulk_insert @@
-15.14%
@@ sysbench/oltp_insert @@
-5.44%
@@ sysbench/oltp_update_index @@
-5.21%
There was a problem hiding this comment.
Code review suggestions:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ util/walkback.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
There was a problem hiding this comment.
Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Error ⚠ .
Cbuild submission: Success ✓.
Regression testing: 4/303 tests failed ⚠.
The first 10 failing tests are:
ssl_crl
mem_tracker
insert_lots
simple_ssl
There was a problem hiding this comment.
Sysbench Transactions Per Second (commit: a404f0e):
@@ sysbench/oltp_read_only @@
-9.35%R7: unlock mutexes before calling destroy on session obj. Port of PR bloomberg#2013.
R7: unlock mutexes before calling destroy on session obj.
Port of PR #2013.