WIP: use gm tpuconnectionmanager for proxy #218
Conversation
grooviegermanikus
commented
Sep 28, 2023
•
grooviegermanikus
commented
- use (copy) tpu_connection_manager and notably active_connection from pratik's implementation
- improve auto connection from lite-rpc to quic-proxy
- will be partially removed
| Shutdown(Pubkey), | ||
| } | ||
|
|
||
| struct ActiveConnection { |
There was a problem hiding this comment.
note: no Clone anymore which IMO is good
| }); | ||
|
|
||
| }, | ||
| Ok(BroadcastMessage::Shutdown(tpu_identity)) => { |
There was a problem hiding this comment.
wdyt? sending shutdown in line with transaction payload in same channel will remove race condition between transactions remaining in queue while connection thread is shutting down
There was a problem hiding this comment.
Ok i think, removes one extra channel.
| @@ -0,0 +1,283 @@ | |||
| #![allow(unused_imports)] | |||
There was a problem hiding this comment.
Can make changes to original code instead of coping it.
| let broadcast_receiver = self.broadcast_sender.subscribe(); | ||
|
|
||
| active_connection.start_listening(broadcast_receiver, max_uni_stream_connections); | ||
| self.identity_to_active_connection.insert( |
There was a problem hiding this comment.
Connections are never removed from this map. They are always added.
There was a problem hiding this comment.
eh! don't scare me ;) - look, I guess you are wrong:
2023-09-29T15:08:05.018721Z INFO update_connections: solana_lite_rpc_quic_forward_proxy::outbound::tpu_connection_manager: identity_to_active_connection: 9
...
2023-09-29T15:08:13.737999Z INFO update_connections: solana_lite_rpc_quic_forward_proxy::outbound::tpu_connection_manager: identity_to_active_connection: 3
| }); | ||
|
|
||
| }, | ||
| Ok(BroadcastMessage::Shutdown(tpu_identity)) => { |
There was a problem hiding this comment.
Ok i think, removes one extra channel.
