Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 2: Upgrade No JS Checkout to Modular #298 #306

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Phase 2: Upgrade No JS Checkout to Modular #298 #306

merged 3 commits into from
Jan 16, 2023

Conversation

thisisayush
Copy link
Contributor

@thisisayush thisisayush commented Dec 28, 2022 •
edited
Loading

References #283
Closes #305
Continuation for #298

No JS Modular Checkout:

  • Upgrades No JS Checkout to Modular

Screenshots:

Lite Mode

image

Normal Mode

image

@thisisayush thisisayush mentioned this pull request Dec 28, 2022
Closed
@shivaenigma
Copy link
Collaborator

Don't do anything in frontend. This is ok

@shivaenigma
Copy link
Collaborator

No refresh functionality

@thisisayush
Copy link
Contributor Author

Related Issues/PR:
#307
#309

The above issues do not affect the current PR in any way, they are additional functionalities/bugs which should be addressed as a separate issue.

@DarrenWestwood DarrenWestwood merged commit 0aa116e into master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarrenWestwood DarrenWestwood DarrenWestwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NOJS modular checkout
3 participants
@thisisayush @shivaenigma @DarrenWestwood