Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ng-src instead scr in IMG tag #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Using ng-src instead scr in IMG tag #102

wants to merge 1 commit into from

Conversation

agarzon
Copy link

@agarzon agarzon commented Nov 13, 2020

close #97

@agarzon agarzon self-assigned this Nov 13, 2020
DarrenWestwood
DarrenWestwood approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@DarrenWestwood DarrenWestwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly prevents the browser from fetching the image with literal text, removes the error message from the console logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarrenWestwood DarrenWestwood DarrenWestwood approved these changes

Assignees

@agarzon agarzon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: 404 calling an image, no active_code value defined
2 participants
@agarzon @DarrenWestwood