Add support for metadata in execution results #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revamp of #156 and #154 that makes not-so-big structural changes, fixes a few bugs and implements some review suggestions.
In order to move things faster and not block the process for too long, I opened this PR instead of going back and forth there, even though the changes aren't huge.
Summary of changes compared to the mentioned PR:
Sidenote - not using metadata changes nothing compared to what we had before.
To use metadata one only needs to add
node.WithMetadataProvider()
config option to thenode
constructor.Sample output of an API response with four nodes is below. The metadata presented is some gibberish just to illustrate the point, and one out of four nodes produces a dummy output just to showcase differing results in the output and how the metadata is moved alongside the relevant execution result.