Database update #146
Merged
Database update #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikey
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new database format. Instead of having two databases like before, now we have a single one. This also eliminates the weird scenario where head node had a function database that it never really used nor needed. Currently we support two types of records - peers and functions - which isn't different from before. This can easily be extended to support more stuff, if needed. Also - the database accepts a configurable codec - we still use JSON, but if needed we could switch to something faster/smaller.
Database format is NOT backwards compatible - I thought that is okay. If there's need we could introduce a migration tool or something like that.
This PR also adds two new config options -
--purge-dialback-peersand--purge-functionswhich enables the node to remove any past peers or functions on startup, if one wants a clean slate.I also added an integration test for
fstorewhich goes through the whole process of function install from an IPFS-deployedhello-worldfunction.