Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemhandling update #424

Merged
merged 8 commits into from
Mar 29, 2025

Conversation

icommitdesnet
Copy link
Contributor

let pickit decide, if we want an upgrade. not sure if solution is acceptable: see function GemUnit(gem) (Town.js 2176)
check for gem upgrade before picking a gemshrine (autoshriner and scanshrine). if there is, even go to town before picking.
removed old code from town.js
no collecting of chipped gems with gem shrines. leave them for others or 1.09

icommitdesnet and others added 8 commits January 3, 2025 18:38
let pickit decide, if we want an upgrade
check for gem upgrade before picking a gemshrine (autoshriner and scanshrine)
no collecting of chipped gems vith gem shrines
fix linting warnings
…ng on start + `dontStashGids` Set

- Moved the `GemUnit` class out from the body of `isUpgradePossible`
- Faster check using `some` instead of `filter` for checking clean invo
- Add `Town.dontStashGids` which is a Set of gids we are not allowed to stash populated during gamplay
- Only attempt taking portal if we moved, this was causing us to take any portal that was ours even if we hadn't gone anywhere
- Clean up GemHunter, use custom `findGemShrines` rather than relying on `Misc.getShrinesInArea` method. `findGemShrines` handles preparing for the next shrine if we've found one and ending early if we have no more gems to use
@theBGuy
Copy link
Contributor

theBGuy commented Mar 29, 2025

Summary

This pull request focuses on enhancing the gem hunting functionality in the d2bs/kolbot bot for Diablo II. The changes include adding new methods for better gem handling and shrine preparation, as well as refactoring existing logic for improved clarity and efficiency.

Enhancements to gem hunting functionality:

Improvements to item handling:

Refactoring of town-related functions:

Updates to the GemHunter script:

@theBGuy theBGuy merged commit 7cc52c2 into blizzhackers:restructure Mar 29, 2025
1 check passed
@theBGuy theBGuy mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants