Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Blitz RPC endpoint to the app directory #860

Merged
merged 22 commits into from
Aug 14, 2024

Conversation

siddhsuresh
Copy link
Member

@siddhsuresh siddhsuresh commented Jun 16, 2024

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blitzjs-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 2:17pm

@siddhsuresh siddhsuresh changed the title docs Docs for https://github.com/blitz-js/blitz/pull/4341 Jun 16, 2024
@siddhsuresh siddhsuresh changed the title Docs for https://github.com/blitz-js/blitz/pull/4341 Docs for Jun 16, 2024
@siddhsuresh siddhsuresh changed the title Docs for Docs for Blitz RPC endpoint to the app directory Jun 16, 2024
Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhere you need to fully document the api, arguments, and return of both withBlitzAuth and rpcAppHandler

Copy link
Member

@flybayer flybayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise the content looks good

Comment on lines 106 to 109
Blitz RPC defaults to: - `verbose` to be true if it not configured. -
The `input` and `resolver completion time` will be logged with the
`info` level. - The `result` and `next.js serialization time` will be
logged with the `debug` level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list formatting is broken


##### Arguments

- `handlers: { [method: string]: Handler })` - An object of handlers where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the list formats seem broken

app/pages/docs/auth-server.mdx Outdated Show resolved Hide resolved
@siddhsuresh siddhsuresh merged commit a083bb6 into main Aug 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants