fix: ensure calling verify_completion with dry_run don't apply events

apps/govquests-api/govquests/gamification/lib/gamification/events.rb

@@ -67,7 +67,6 @@ class BadgeCreated < Infra::Event
   class BadgeUnlocked < Infra::Event
     attribute :badge_id, Infra::Types::UUID
     attribute :user_id, Infra::Types::UUID
-    attribute :notify, Infra::Types::Bool
   end
 
   class BadgeEarned < Infra::Event

apps/govquests-api/govquests/gamification/lib/gamification/special_badge.rb

@@ -36,11 +36,14 @@ def verify_completion?(user_id:, dry_run: false)
       strategy = Gamification::SpecialBadgeStrategyFactory.for(@badge_type, badge_data: @badge_data, user_id: user_id, unlocked_by: @unlocked_by)
       can_complete = strategy.verify_completion?
 
-      apply BadgeUnlocked.new(data: {
-        badge_id: @id,
-        user_id: user_id,
-        notify: !dry_run
-      }) if can_complete
+      if can_complete
+        apply BadgeUnlocked.new(data: {
+          badge_id: @id,
+          user_id: user_id,
+        }) unless dry_run
+
+        @unlocked_by << user_id if dry_run
+      end  
 
       can_complete
     end

apps/govquests-api/govquests/processes/lib/processes/notify_on_badge_unlocked.rb

@@ -20,7 +20,7 @@ def call(event)
           content: "New <a href='/achievements?badgeId=#{badge_id}'>badge</a> unlocked!",
           notification_type: "badge_unlocked"
         )
-      ) if event.data[:notify]
+      )
     end
   end
 end