Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job): log was too long (closes #556) #557

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MrCyjaneK
Copy link
Contributor

Fix issue #556, caused by the log being too long to fit in the table

I didn't test it (yet), but it should fix the issue.

@MrCyjaneK
Copy link
Contributor Author

I've restarted the build and it didn't crash this time - so I guess that it works.

@MrCyjaneK
Copy link
Contributor Author

Error 1406: Data too long for column 'commit_message' at row 1. I'll fix this also tonight

@@ -5,7 +5,7 @@ type (
EnvVariable struct {
ID uint `gorm:"primary_key;auto_increment;not null" json:"id"`
Key string `gorm:"not null" json:"key"`
Value string `gorm:"not null" sql:"type:text" json:"value"`
Value string `gorm:"not null" sql:"type:longtext" json:"value"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works for mysql unfortunately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I have no idea how to fix it for sqlite, except for truncating the actual value...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I tested, longtext works just fine in here with sqlite3 as backend, and if I got the docs correctly - sqlite doesn't limit the size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for the test, i will also test it and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants