Skip to content

Commit

Permalink
Remove unused $aggregate variable.
Browse files Browse the repository at this point in the history
Hasn't _ever_ been used, and 11yrs later, I cannot remember why I
thought I needed it.  /shrug
  • Loading branch information
bleargh45 committed Jan 6, 2021
1 parent e866e4d commit c0b1ca4
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Revision history for Perl extension TAP::Formatter::JUnit.
{{$NEXT}}
- Switch to Dist::Zilla for release management.
- Various POD fixups; syntax, spelling
- Cleaned up and removed unused variables

0.11 Wed Oct 1 13:26 PDT 2014
- Use "IPC::Run" instead of "IPC::Open2" in tests, to fix problems with
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ moment and needed to be able to generate JUnit output for.
Creates a `TAP::Formatter::JUnit::Session` session, instead of a console
formatter session.

- **summary($aggregate)**
- **summary()**

Prints the summary report (in JUnit) after all tests are run.

Expand Down
6 changes: 3 additions & 3 deletions lib/TAP/Formatter/JUnit.pm
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ sub open_test {
}

###############################################################################
# Subroutine: summary($aggregate)
# Subroutine: summary()
###############################################################################
# Prints the summary report (in JUnit) after all tests are run.
sub summary {
my ($self, $aggregate) = @_;
my $self = shift;
return if $self->silent();

my @suites = @{$self->testsuites};
Expand Down Expand Up @@ -140,7 +140,7 @@ Over-ridden C<open_test()> method.
Creates a C<TAP::Formatter::JUnit::Session> session, instead of a console
formatter session.
=item B<summary($aggregate)>
=item B<summary()>
Prints the summary report (in JUnit) after all tests are run.
Expand Down
2 changes: 1 addition & 1 deletion script/tap2junit
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ foreach my $file (@tap_files) {
$aggregator->stop();

# Summarize the results (in JUnit)
$formatter->summary($aggregator);
$formatter->summary;
};
if ($@) {
warn $@;
Expand Down

0 comments on commit c0b1ca4

Please sign in to comment.