Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Edit + Delete + Marker Control #1317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nickcastel50
Copy link
Contributor

@nickcastel50 nickcastel50 commented Jan 8, 2025

  • added edit / delete comment
  • addressed marker behavior in those conditions
  • marker bug fixes

Addresses #1186

Should approve #1316 first, then I will merge and add Percy link.

Edit: https://percy.io/8fe2b2f1/web/share/builds/38405723

@nickcastel50 nickcastel50 added the enhancement New feature or request label Jan 8, 2025
@nickcastel50 nickcastel50 self-assigned this Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 6401b26
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/67982435d48a44000804a782
😎 Deploy Preview https://deploy-preview-1317--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit 6401b26
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/67982435c94eb400081d4570
😎 Deploy Preview https://deploy-preview-1317--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickcastel50 nickcastel50 marked this pull request as ready for review January 9, 2025 04:55
@pablo-mayrgundter
Copy link
Member

#1316 is in, so this should be merged and needs a percy run as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants