Fix inline list rendering in live preview #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacksmithgu
approved these changes
Jul 16, 2024
|
Thanks! |
|
Thank you both! |
reply2za
added a commit
to reply2za/obsidian-dataview
that referenced
this pull request
Aug 16, 2024
This reverts commit 6a6e025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2385, #2281.
In live preview, only the last item of the list would display. Reading view displayed the fields correctly. This PR resolves such rendering issues in live preview.
Tested locally to ensure that lists are now rendered as expected.
Edits are formatted & all tests pass.
Example
Source
Live Preview Before
Live Preview After