Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ttypescript to 1.5.15 to fix a compile failure when using node >=16.18 #2021

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

albertsj1
Copy link
Contributor

Currently, cloning this repo, running npm install or even npm ci installs ttypescript 1.5.13. Using this version of ttypescript causes the npm run dev command to fail with the following error:

npm run dev

> [email protected] dev
> npx rollup --config rollup.config.js -w

[!] TypeError: Cannot set property constructor of [object Object] which has only a getter
TypeError: Cannot set property constructor of [object Object] which has only a getter
    at new __ (/Users/johnalb/src/personal/obsidian_dev/obsidian-dataview/node_modules/ttypescript/lib/loadTypescript.js:13:42)
    at __extends (/Users/johnalb/src/personal/obsidian_dev/obsidian-dataview/node_modules/ttypescript/lib/loadTypescript.js:14:84)
    at /Users/johnalb/src/personal/obsidian_dev/obsidian-dataview/node_modules/ttypescript/lib/loadTypescript.js:65:5
    at Object.<anonymous> (/Users/johnalb/src/personal/obsidian_dev/obsidian-dataview/node_modules/ttypescript/lib/loadTypescript.js:100:2)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Object.require.extensions.<computed> [as .js] (/Users/johnalb/src/personal/obsidian_dev/obsidian-dataview/node_modules/rollup/dist/shared/loadConfigFile.js:617:17)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Function.Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)

Updating to ttypescript 1.5.15 fixes this bug.

@lomky
Copy link

lomky commented Sep 15, 2023

Could a maintainer please run the workflows on this PR? without this the main branch is broken so all other PRs will fail

rocketnova added a commit to sneaky-foxes/obsidian-dataview that referenced this pull request Sep 15, 2023
@blacksmithgu blacksmithgu merged commit 1240b16 into blacksmithgu:master Sep 15, 2023
2 of 3 checks passed
blacksmithgu pushed a commit that referenced this pull request Sep 15, 2023
* Add support for frontmatter links. Requires obsidian v1.4.0+.

* Run prettier.

* Fix format check CI job. See #2046.

* Fix build CI job. See #2021.
@albertsj1 albertsj1 deleted the update_ttypescript branch September 15, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to load TS on node >= 16.18
3 participants