Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Husky commit hooks #141

Open
blackjackkent opened this issue Dec 3, 2020 · 0 comments
Open

Add Husky commit hooks #141

blackjackkent opened this issue Dec 3, 2020 · 0 comments
Labels
devops Non-user-facing updates.

Comments

@blackjackkent
Copy link
Owner

Expected Behavior

When pushing a branch, devs should be required to verify that tests and linting are all passing before opening a pull request. We can use Husky shared commit hooks for this.

Actual Behavior

No push hooks exist to check for successful build.

Steps to Reproduce the Problem

  1. Commit to a feature branch that has failing linting or tests.
  2. Push this branch.
  3. Push succeeds when it should not be allowed.
@blackjackkent blackjackkent added the devops Non-user-facing updates. label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Non-user-facing updates.
Projects
None yet
Development

No branches or pull requests

1 participant