Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Improve pod annotation mgmt with multiple events #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xenserverarmy
Copy link
Collaborator

  • Resolve race conditions wrt short lived pods
  • Rescan if pod only representation of an image is encountered
  • Add sweeper pod annotation model to catch pods which couldn't be annotated upon creation

Test environments:

  • OCP 3.5, OCP 3.6, OCP 3.7, Kube 1.8 (Heptio)

Test scenarios:

  • Scale pod up, observed pod annotations
  • Scale pod down and the up and observe correct annotations
  • Upgrade version of ose_scanner and observe pods without image streams are correctly annotated
  • In build pipeline observe builder and deployer pods are identified and annotated
  • When git trigger occurs, builder pods are identified and annotated

Copy link
Contributor

@jayunit100 jayunit100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review, minor nit function comments otherwise LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants