Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

first unit test #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

first unit test #19

wants to merge 1 commit into from

Conversation

mattfenwick
Copy link
Contributor

First unit test -- this does two things:

  • splits scanAbort into testable logic and the code that works with all the dependencies
  • adds a unit test verifying the behavior of scanAbortLogic in the case that no controller daemon can be found

@xenserverarmy
Copy link
Collaborator

Please detail how this was tested in a real cluster. PRs need to include production tests to ensure we haven't destabilized the system due to changes.

As an example, you'll need to include what version of OpenShift Cloud Platform you've targetted, what image monitoring options were tested. Since you're making modifications which impact the protocol between two containers running on different nodes, this is an important thing to verify.

Note that I don't see any issues with the code changes, but want you to confirm functional testing before the merge occurs. To give an idea of what I'm looking for see #18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants