Add stats endpoint #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdissent
approved these changes
Apr 19, 2018
rochforp
reviewed
Apr 19, 2018
|
|
||
| Example Request: | ||
| ``` | ||
| https://my.phy.net/api/v2/metrics/stats?metric=scans&from=1521561000000&to=1524153000000&dimension=activity&value=all&interval=day |
There was a problem hiding this comment.
Are 'from' and 'to' supposed to be swapped here?
There was a problem hiding this comment.
The request I was using that is working is structured a little different
"https://my.phy.net/api/v2/metrics/stats?metric=scans&dimension=phyid&value=all&to=1523982165633&from=1523896360822&interval=day"
dimension followed by value with interval at the end
There was a problem hiding this comment.
@rochforp The order does not matter with query variables, as long as the keys are unique. They are parsed into an object and accessed from that.
rochforp
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for our
statsmetrics endpoint.