Another fix for crashing with VK_DEVICE_LOST #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look at it tomorrow most likely. You change looks plausible. It's been a while since looked into this. Could you break down why this change would be correct? |
|
The same reason you put this comment in. |
|
I took some time to think about it, and it looks 100% reasonable that that would also be required. @bkaradzic I think this can be merged. I haven't tested anything, but the change looks correct. |
mcourteaux
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was still getting some VK_DEVICE_LOST crashes and this fixes it. Followed some changes from 01af383#diff-4fe4dacbf31bf95719870316660d20e1deca6ebbfa3f39c6b2b8b0b302d629f9
@mcourteaux Does this look right to you?