Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing color order for RGB10A2 on vulkan. #3403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing color order for RGB10A2 on vulkan. #3403

wants to merge 2 commits into from

Conversation

mtytel
Copy link
Contributor

@mtytel mtytel commented Jan 28, 2025

Not sure why this was flipped but this fixes RGB10A2 frame buffer colors on vulkan.

@bkaradzic
Copy link
Owner

What is wrong with it?

image

@mtytel
Copy link
Contributor Author

mtytel commented Jan 28, 2025

Hmm, ok that example is correct.
But if I change the RGBA32F frame buffers in the 38-bloom example to RGB10A2 format. R and B are flipped.
RGBA32F:
image

RGB10A2:
image

@mtytel
Copy link
Contributor Author

mtytel commented Jan 28, 2025

OK, now this change seems to make both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtytel @bkaradzic