-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A custom workflow #6
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
be13344
add team notes on automation
hectorsector 73070c4
bump node-forge
lmkeston 26050fc
Merge main into team-workflow
github-learning-lab[bot] 4d940ca
Create approval-workflow.yml
bjornvolcker 787cdde
Update approval-workflow.yml
bjornvolcker 46f3b21
Update approval-workflow.yml
bjornvolcker 2994b93
Update approval-workflow.yml
bjornvolcker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||||||||
name: Team awesome's approval workflow | ||||||||||||
on: pull_request_review | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Step 16: Create an approval job in your new workflow⌨️ Activity: In your new workflow file, create a new job that'll use the community action
I'll respond when you commit something to this branch. |
||||||||||||
jobs: | ||||||||||||
labelWhenApproved: | ||||||||||||
name: Label when approved | ||||||||||||
runs-on: ubuntu-latest | ||||||||||||
steps: | ||||||||||||
- name: Label when approved | ||||||||||||
uses: pullreminders/label-when-approved-action@master | ||||||||||||
env: | ||||||||||||
APPROVALS: "1" | ||||||||||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||||||||
ADD_LABEL: "approved" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
The team would like: | ||
- [ ] branch protections | ||
- [ ] required review approvals | ||
- [ ] easy way to see when enough approvals has been achieved | ||
- [ ] matrix build | ||
- [ ] save build artifacts | ||
- [ ] dedicated test job |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 15: Use an action to automate pull request reviews
Trigger your review workflow. Apply the suggestion or follow the instructions to do it directly.
⌨️ Activity: Use the community action in your new workflow
I'll respond when you commit something to this branch.