Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A custom workflow #6

Merged
merged 7 commits into from
Jun 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/approval-workflow.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Team awesome's approval workflow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 15: Use an action to automate pull request reviews

Trigger your review workflow. Apply the suggestion or follow the instructions to do it directly.

⌨️ Activity: Use the community action in your new workflow

Suggested change
name: Team awesome's approval workflow
name: Team awesome's approval workflow
on: pull_request_review
  1. Edit your newly created workflow file
  2. Below the title, run the workflow on a pull request review event:
    on: pull_request_review
  3. Commit your changes to this branch

I'll respond when you commit something to this branch.

on: pull_request_review
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 16: Create an approval job in your new workflow

⌨️ Activity: In your new workflow file, create a new job that'll use the community action

  1. Edit your newly created workflow file
  2. Create a new job called labelWhenApproved.
    Suggested change
    on: pull_request_review
    on: pull_request_review
    jobs:
    labelWhenApproved:
    runs-on: ubuntu-latest
  3. Commit your changes to this branch

I'll respond when you commit something to this branch.

jobs:
labelWhenApproved:
name: Label when approved
runs-on: ubuntu-latest
steps:
- name: Label when approved
uses: pullreminders/label-when-approved-action@master
env:
APPROVALS: "1"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ADD_LABEL: "approved"
7 changes: 7 additions & 0 deletions automation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
The team would like:
- [ ] branch protections
- [ ] required review approvals
- [ ] easy way to see when enough approvals has been achieved
- [ ] matrix build
- [ ] save build artifacts
- [ ] dedicated test job