Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #5

Merged
merged 7 commits into from
Jun 15, 2021
Merged

Improve CI #5

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2aa37d
Improve CI
bjornvolcker Jun 15, 2021
51d093b
Update node.js.yml
bjornvolcker Jun 15, 2021
db10c76
Update node.js.yml
bjornvolcker Jun 15, 2021
a56296b
Update node.js.yml
bjornvolcker Jun 15, 2021
f14c17d
Update node.js.yml
bjornvolcker Jun 15, 2021
d230f8b
Update .github/workflows/node.js.yml
bjornvolcker Jun 15, 2021
b8e924a
Update node.js.yml
bjornvolcker Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,30 @@ on:

jobs:
build:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: npm install and build webpack
run: |
npm install
npm run build

test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
test:
needs: build

runs-on: ubuntu-latest
strategy:
bjornvolcker marked this conversation as resolved.
Show resolved Hide resolved
matrix:
node-version: [10.x, 12.x, 14.x, 15.x]
os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Target a Windows environment

Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.

⌨️ Activity: Edit your workflow file to build for Windows environments

an icon of three gears

You can follow the suggestion, or manually make the changes in the numbered instructions.

Suggested change
node-version: [12.x, 14.x]
os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
  1. Edit the workflow config at .github/workflows/nodejs.yml
  2. Add an os field to the strategy.matrix section of your workflow
  3. Add ubuntu-latest and windows-2016 to the target operating systems
  4. Commit your workflow changes to this branch.

I'll respond in this pull request when you've committed.

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v1
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
with:
- uses: actions/download-artifact@main
with:
name: webpack artifacts
path: public
- name: npm install, and test

node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run build --if-present
- run: npm test
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true