Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added S3 versioning support #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeip0
Copy link
Contributor

  • added ability to get/delete specific version of an object
  • added ability to list all versions of the bucket objects

- added ability to get/delete specific version of an object
- added ability to list all versions of the bucket objects
@bji
Copy link
Owner

bji commented Aug 21, 2018

Thank you for your great changes, as you can see i don't really have anything to do with this project any more and I have not been particularly good about merging pull requests in a timely fashion, but your work is appreciated. Please just address the minor issue I raised above and I will merge this request.

@alexeip0
Copy link
Contributor Author

Sorry, having hard time finding the minor issue I have to address. Is there a comment somewhere I'm not seeing?

@bji
Copy link
Owner

bji commented Sep 10, 2018

The minor issue is the question I asked above ... you have documented the version id as being 'null' if the object was created before versioning was available ... I think that the comment should be updated because it's ambiguous: 'null' could mean the string "null" or it could mean the zero-value null ... just wanted the docs to be clearer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants