Merge pull request #647 from bitzesty/restrict-assessor-view-form-sup…

…porters remove ability for assessors/lieutenants to delete support letters
bitzesty · Feb 1, 2024 · 6f57517 · 6f57517
2 parents d61a737 + 60fb69e
commit 6f57517
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/controllers/form/support_letters_controller.rb b/app/controllers/form/support_letters_controller.rb
@@ -30,6 +30,9 @@ def new
   end
 
   def destroy
+    # safeguard for the case when not a user tries to delete a letter
+    return if current_assessor || current_leutenant
+
     if @support_letter.destroy
       remove_support_letter_from_document!
       @form_answer.save

diff --git a/app/views/qae_form/_supporter_fields.html.slim b/app/views/qae_form/_supporter_fields.html.slim
@@ -43,7 +43,7 @@ li.js-add-example class="#{'read-only js-support-letter-received' if persisted}"
     button.govuk-button.js-save-collection class=(persisted ? "visuallyhidden" : "") data-save-collection-url=users_form_answer_support_letters_url(@form_answer)
       | Submit letter of support
 
-  - if current_form_is_editable?
+  - if current_form_is_editable? && !current_lieutenant && !current_assessor
     - if persisted
       - if supporter["support_letter_id"].present? && @form_answer.support_letters.find_by_id(supporter["support_letter_id"])
         - url = users_form_answer_support_letter_path(form_answer_id: @form_answer.id, id: supporter["support_letter_id"])