-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and release workflows with tooling #21
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRE will really be the official reviewers here and can work on that final setup, but I saw a few things.
Hi @withinfocus, thanks a lot for your feedback. I hope I was able to address all the remarks you made. There is just open follow-up question from my side regarding the the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the optimization of the secrets-related steps in the workflows, I think I am good with this and BRE should get in for their review.
98cea93
to
201fd60
Compare
201fd60
to
f8f3ee5
Compare
Closed and re-opened the PR to fire a new workflow linter. @tgraupne, please also fix the things indicated by it: https://github.com/bitwarden/terraform-provider-bitwarden-sm/actions/runs/12908630218/job/35994555617?pr=21 |
1cffc90
to
ab606e4
Compare
Hi @michalchecinski, I tried to incorporate all of your feedback and I create a little miro board showing the implemented GitHub Actions workflows. With that, I am trying to make sure that there are nor misunderstandings in the process we'd like to implement together. I am looking forward to your feedback. |
* since this file is not in scope, undo all
* updated release workflow
* updated release workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to hold anything up for merging. Can iterate if needed later and BRE really owns these flows.
This PR contains updated to our GitHUb Actions Workflows in preparation of the release of our terraform provider.
Example executions of the release-workflow triggered by pushing a tag can be found here:
https://github.com/bitwarden/terraform-provider-bitwarden-sm/actions/runs/10579959606
We followed hashicorps documentation about the manual release preparation:
https://developer.hashicorp.com/terraform/registry/providers/publishing#manually-preparing-a-release
The following things are still open:
we need to setup a signing key in order to sign the hashes of our binaries
we need to decide if we can use large hosted runners in GitHub Actions in order to provide a native ubuntu environment to build arm64 binaries
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes