Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-3006] Splunk app UI rewrite #63

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mzieniukbw
Copy link
Contributor

@mzieniukbw mzieniukbw commented Sep 7, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-3006

📔 Objective

Rewrite the Splunk UI of the Bitwarden Event Logs application.
Technology: Node, Angular v18, Tailwind
Rewrite Benefits:

  • Unified tech stack
  • Better User Experience (visually nicer and consistent)
  • Validation of fields (required fields, email)
  • Error handling
  • Reads the app configuration on load (Url, index, date)

Other:

📷 Screenshots

Note: Splunk CSS seems to override a lot of things, but maybe that's for better, since it's more Splunk native look.

No errors:

image

Save success:

image

Validation issues:

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

github-actions bot commented Sep 7, 2024

Logo
Checkmarx One – Scan Summary & Detailsadd86c39-3123-4b82-bcbb-0ba6d96205c4

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Password /docker-compose.yml: 30 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /docker-compose.yml: 19 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /docker-compose.yml: 7 Query to find passwords and secrets in infrastructure code.
MEDIUM Client_Privacy_Violation /ui/projects/setup/src/app/app.component.html: 77 Attack Vector
MEDIUM Client_Privacy_Violation /ui/projects/setup/src/app/app.component.html: 77 Attack Vector
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 31 Incoming container traffic should be bound to a specific host interface
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 20 Incoming container traffic should be bound to a specific host interface
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 8 Incoming container traffic should be bound to a specific host interface
MEDIUM Healthcheck Not Set /docker-compose.yml: 25 Check containers periodically to see if they are running properly.
MEDIUM Healthcheck Not Set /docker-compose.yml: 14 Check containers periodically to see if they are running properly.
MEDIUM Security Opt Not Set /docker-compose.yml: 14 Attribute 'security_opt' should be defined.
MEDIUM Security Opt Not Set /docker-compose.yml: 25 Attribute 'security_opt' should be defined.
MEDIUM Unpinned Actions Full Length Commit SHA /build.yml: 166 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Container Capabilities Unrestricted /docker-compose.yml: 25 Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnecessa...
LOW Container Capabilities Unrestricted /docker-compose.yml: 14 Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnecessa...
LOW Unsafe_Use_Of_Target_blank /ui/projects/setup/src/app/app.component.html: 35 Attack Vector
LOW Unsafe_Use_Of_Target_blank /ui/projects/setup/src/app/app.component.html: 21 Attack Vector
LOW Use_Of_Hardcoded_Password /ui/projects/setup/src/splunk/splunk-js.service.ts: 144 Attack Vector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant