Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity path to database test workflow #5401

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

rkac-bw
Copy link
Contributor

@rkac-bw rkac-bw commented Feb 13, 2025

🎟️ Tracking

📔 Objective

Add additional workflow path like src/**/Entity/**/.cs to catch all relevant entity changes that could require migrations

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@rkac-bw rkac-bw requested a review from a team as a code owner February 13, 2025 03:25
@rkac-bw rkac-bw requested a review from dani-garcia February 13, 2025 03:25
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.45%. Comparing base (c3924bb) to head (b7f7739).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5401   +/-   ##
=======================================
  Coverage   44.45%   44.45%           
=======================================
  Files        1500     1500           
  Lines       69646    69646           
  Branches     6264     6264           
=======================================
  Hits        30964    30964           
  Misses      37357    37357           
  Partials     1325     1325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Logo
Checkmarx One – Scan Summary & Details677beadb-608e-4ce9-bda1-4136a6603428

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 248
detailsMethod PushAuthRequestAsync at line 248 of /src/Core/NotificationHub/NotificationHubPushNotificationService.cs sends user information outside the a...
Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 531
detailsMethod PutCollectionManagement at line 531 of /src/Api/AdminConsole/Controllers/OrganizationsController.cs gets user input from element model. This...
Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 204
detailsMethod Put at line 204 of /src/Api/AdminConsole/Controllers/OrganizationsController.cs gets user input from element model. This element’s value flo...
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 221
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 230

Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in the pull_request -> paths section too.

@rkac-bw rkac-bw requested a review from justindbaur February 13, 2025 14:03
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rkac-bw rkac-bw merged commit 6cb00eb into main Feb 13, 2025
56 checks passed
@rkac-bw rkac-bw deleted the fix-workflow-entity-paths branch February 13, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants